Add reasoningMode and getChatById to DuckAiChat Store#8659
Merged
Conversation
This was referenced May 21, 2026
Collaborator
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 7738d8f. Configure here.
7738d8f to
e4ba144
Compare
Base automatically changed from
feature/youssef/ai_reasoning_effort_upsell
to
develop
May 21, 2026 20:37
e4ba144 to
a380f28
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Task/Issue URL: https://app.asana.com/1/137249556945/project/1212810093780571/task/1215002056518125?focus=true
Description
Per-chat reasoning persistence groundwork (1 of 3).
The FE has been storing a
reasoningModefield per chat in the JSON blob it pushes to native storage, but Android wasn't reading it. This PR starts extracting that field on the read side so it's available to consumers, and adds a single-chat lookup API to the store. No behavioural change yet - the new field isn't consumed by any feature in this PR.The follow-up PR will use this data to populate the reasoning picker correctly when the user opens an existing chat (showing the chat's stored mode rather than the global default).
What changed:
DuckAiChatAdded a nullablereasoningMode: String?field.getChatById** onDuckAiChatStore. Wraps the existingchatsDao.getById(chatId)`.No migration required. Room only stores
(chatId, data)wheredatais the raw FE blob, we just parse a new field at read time.Steps to test this PR
UI changes
N/A — data-layer only.
Note
Low Risk
Low risk data-layer change that only extends the parsed chat metadata and adds a read-only lookup API; main risk is minor integration/consumer expectations around null/empty
reasoningModehandling.Overview
Adds per-chat
reasoningMode: String?toDuckAiChatand updates JSON parsing to populate it while treating missing, empty, or explicit JSONnullasnull.Extends
DuckAiChatStorewithgetChatById(chatId)(implemented inRealDuckAiChatStore) to fetch and parse a single chat, and adds unit tests coveringreasoningModeparsing and the new lookup behavior (not found / malformed JSON).Reviewed by Cursor Bugbot for commit a380f28. Bugbot is set up for automated code reviews on this repo. Configure here.