Skip to content

Conversation

@malmstein
Copy link
Contributor

Task/Issue URL: https://app.asana.com/0/488551667048375/1182605057307457

Description:
As part of Test improvements to the double search header we added a new pixel because. We should have only added this for the SERP Header Removal Experiment Variant, but it was enabled for all experiments.

Objective
Fix this, so the Pixel is only fired in this variant

Steps to test this PR:
SERP Header Removal Variant

  1. Enable variant zi
  2. Open the app
  3. Type a query in the native toolbar
  4. Check that pixel rq_1 has been fired
  5. Type the same query again
  6. Check that the pixel rq_0 has been fired

Control group

  1. Enable variant zg
  2. Open the app
  3. Type a query in the native toolbar
  4. Check that pixel rq_1 has not been fired
  5. Type the same query again
  6. Check that the pixel rq_0 has not been fired

Internal references:

Software Engineering Expectations
Technical Design Template

@malmstein malmstein changed the title this pixel should only be fired in the serp header removal variant Rq Pixel should only be fired in SERP Header removal experiment Jun 30, 2020
@cmonfortep
Copy link
Contributor

❤ those two last commits

Copy link
Contributor

@cmonfortep cmonfortep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested and works as described 👍

@cmonfortep cmonfortep merged commit 7bb0755 into develop Jul 1, 2020
@cmonfortep cmonfortep deleted the feature/david/fix_rq_pixel branch July 1, 2020 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants