Skip to content

Rq Pixel should only be fired in SERP Header removal experiment #875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 1, 2020
Merged

Rq Pixel should only be fired in SERP Header removal experiment #875

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9593912
this pixel should only be fired in the serp header removal variant
malmstein Jun 30, 2020
f73d81a
renaming these to match the actual content of the variable
malmstein Jun 30, 2020
176d165
formatting is your friend
malmstein Jun 30, 2020
928f155
exit sooner rather than later
malmstein Jun 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 7 additions & 14 deletions app/src/main/java/com/duckduckgo/app/browser/BrowserTabViewModel.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,6 @@ import kotlinx.coroutines.Job
import kotlinx.coroutines.launch
import kotlinx.coroutines.withContext
import timber.log.Timber
import java.lang.UnsupportedOperationException
import java.util.Locale
import java.util.concurrent.TimeUnit

Expand Down Expand Up @@ -451,25 +450,19 @@ class BrowserTabViewModel(
}

private fun fireQueryChangedPixel(omnibarText: String) {
val oldUri = currentOmnibarViewState().omnibarText.toUri()
val newUri = omnibarText.toUri()

val oldParameter = try {
oldUri.getQueryParameter(AppUrl.ParamKey.QUERY)
} catch (e: UnsupportedOperationException) {
null
}
val newParameter = try {
newUri.getQueryParameter(AppUrl.ParamKey.QUERY)
} catch (e: UnsupportedOperationException) {
null
if (!variantManager.getVariant().hasFeature(VariantManager.VariantFeature.SerpHeaderRemoval)) {
return
}

if (oldParameter == newParameter) {
val oldQuery = currentOmnibarViewState().omnibarText.toUri()
val newQuery = omnibarText.toUri()

if (oldQuery == newQuery) {
pixel.fire(String.format(Locale.US, PixelName.SERP_REQUERY.pixelName, PixelParameter.SERP_QUERY_NOT_CHANGED))
} else {
pixel.fire(String.format(Locale.US, PixelName.SERP_REQUERY.pixelName, PixelParameter.SERP_QUERY_CHANGED))
}

}

private fun shouldClearHistoryOnNewQuery(): Boolean {
Expand Down