Don't unregister shortcut receiver #881
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1125189844152671/1183093181516711
Tech Design URL:
CC:
Description:
App crashes when unregistering twice on application stopped. We don't really need to unregister here because it is done when the app gets killed anyways as per the documentation
If you register with the Application context, you receive broadcasts as long as the app is running.Steps to test this PR:
Reproduce the crash
unregisterReceiver(shortcutReceiver)below the one that already exists in theDuckDuckGoApplication(line 317).Make sure the toast doesn't crash the app when is taken to the background by an OEM
@CDRussell might be able to help with this one. This is an edge case that we have not been able to test yet.
Normal test
Internal references:
Software Engineering Expectations
Technical Design Template