Skip to content

Don't unregister shortcut receiver #881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 5, 2020
Merged

Don't unregister shortcut receiver #881

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions app/src/main/java/com/duckduckgo/app/global/DuckDuckGoApplication.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,6 +194,7 @@ open class DuckDuckGoApplication : HasAndroidInjector, Application(), LifecycleO
scheduleOfflinePixels()

notificationRegistrar.registerApp()
registerReceiver(shortcutReceiver, IntentFilter(ShortcutBuilder.USE_OUR_APP_SHORTCUT_ADDED_ACTION))

initializeHttpsUpgrader()
submitUnsentFirePixels()
Expand Down Expand Up @@ -299,7 +300,6 @@ open class DuckDuckGoApplication : HasAndroidInjector, Application(), LifecycleO
Timber.i("Suppressing app launch pixel")
return
}
registerReceiver(shortcutReceiver, IntentFilter(ShortcutBuilder.USE_OUR_APP_SHORTCUT_ADDED_ACTION))
pixel.fire(APP_LAUNCH)
}

Expand All @@ -312,11 +312,6 @@ open class DuckDuckGoApplication : HasAndroidInjector, Application(), LifecycleO
}
}

@OnLifecycleEvent(Lifecycle.Event.ON_STOP)
fun onAppStopped() {
unregisterReceiver(shortcutReceiver)
}

companion object {
private const val APP_RESTART_CAUSED_BY_FIRE_GRACE_PERIOD: Long = 10_000L
}
Expand Down