Skip to content

Run non-release-blocking e2e tests independently#8932

Merged
catalinradoiu merged 1 commit into
developfrom
fix/cradoiu/run-non-release-blocking-tests-independently
Jun 19, 2026
Merged

Run non-release-blocking e2e tests independently#8932
catalinradoiu merged 1 commit into
developfrom
fix/cradoiu/run-non-release-blocking-tests-independently

Conversation

@catalinradoiu

@catalinradoiu catalinradoiu commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

Task/Issue URL: https://app.asana.com/1/137249556945/project/1211724162604201/task/1215827024665943?focus=true
Tech Design URL (if applicable):

Description

Test suites in the non-release-blocking e2e nightly (e2e-nightly-non-blockers-suite.yml) ran as sequential steps in a single job. GitHub Actions stops a job at the first failing step, so when an early suite (e.g. Unified Input Field) failed, every suite after it (e.g. Internal Onboarding Flows) was skipped. The suites are independent — each only needs the Maestro binary that was uploaded earlier in the job — so a single failure hid all subsequent failures until the next nightly.

This adds an if: ${{ !cancelled() && steps.<upload>.outcome == 'success' }} guard to each of the five test-suite steps so every suite runs regardless of earlier suite failures, gated only on the binary it consumes.

Steps to test this PR

CI passes

UI changes

Before After
No UI changes No UI changes

Each test suite in the non-blockers nightly was a sequential step in a
single job, so the first failing suite aborted every suite after it. The
suites are independent and only need the uploaded Maestro binary, so a
single failure hid all subsequent ones until the next nightly.

Add an `if: ${{ !cancelled() && steps.<upload>.outcome == 'success' }}`
guard to each test step so every suite runs regardless of earlier suite
failures, gated only on the binary it consumes. The job still ends red
when any suite fails (so the workflow-failure Asana task still fires),
and each failing suite still files its own per-suite Asana task.

https://app.asana.com/1/137249556945/project/1211724162604201/task/1215827024665943

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Copy link
Copy Markdown
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@nalcalag nalcalag left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@catalinradoiu catalinradoiu changed the title Run non-release-blocking e2e suites independently Run non-release-blocking e2e tests independently Jun 19, 2026
@catalinradoiu catalinradoiu merged commit 38ab7d1 into develop Jun 19, 2026
22 of 25 checks passed
@catalinradoiu catalinradoiu deleted the fix/cradoiu/run-non-release-blocking-tests-independently branch June 19, 2026 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants