Skip to content

Conversation

@shakyShane
Copy link
Contributor

@shakyShane shakyShane commented Oct 29, 2024

Asana Task/Github Issue: https://app.asana.com/0/1201141132935289/1208651482829357/f

Description

back-porting changes to the Customizer Menu. not all elements in the future will require synchronization, so this change decouples it.

Testing Steps

Checklist

Please tick all that apply:

  • I have tested this change locally
  • I have tested this change locally in all supported browsers
  • This change will be visible to users
  • I have added automated tests that cover this change
  • I have ensured the change is gated by config
  • This change was covered by a ship review
  • This change was covered by a tech design
  • Any dependent config has been merged

@shakyShane
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @shakyShane and the rest of your teammates on Graphite Graphite

@netlify
Copy link

netlify bot commented Oct 29, 2024

Deploy Preview for content-scope-scripts ready!

Name Link
🔨 Latest commit 169144d
🔍 Latest deploy log https://app.netlify.com/sites/content-scope-scripts/deploys/67211d6207b5db00075b0a96
😎 Deploy Preview https://deploy-preview-1177--content-scope-scripts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link

github-actions bot commented Oct 29, 2024

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

@github-actions
Copy link

github-actions bot commented Oct 29, 2024

[Beta] Generated file diff

Time updated: Tue, 29 Oct 2024 17:44:30 GMT

Android
    - android/pages/duckplayer/js/index.js

File has changed

Integration
    - integration/pages/duckplayer/js/index.js
  • integration/pages/example/js/index.js
  • integration/pages/new-tab/js/index.css
  • integration/pages/new-tab/js/index.js
  • integration/pages/new-tab/js/mock-transport.js
  • integration/pages/onboarding/js/index.js
  • integration/pages/release-notes/js/index.js
  • integration/pages/special-error/js/index.js

File has changed

Windows
    - windows/pages/duckplayer/js/index.js
  • windows/pages/new-tab/js/index.css
  • windows/pages/new-tab/js/index.js
  • windows/pages/new-tab/js/mock-transport.js
  • windows/pages/onboarding/js/index.js

File has changed

Apple
    - dist/pages/duckplayer/index.html
  • dist/pages/duckplayer/js/index.js
  • dist/pages/onboarding/js/index.js
  • dist/pages/release-notes/js/index.js
  • dist/pages/special-error/index.html
  • dist/pages/special-error/js/index.js

File has changed

@shakyShane shakyShane marked this pull request as ready for review October 29, 2024 17:43
@shakyShane shakyShane requested review from a team and mgurgel as code owners October 29, 2024 17:43
Copy link
Contributor

@mgurgel mgurgel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@shakyShane shakyShane merged commit 9a2d05d into main Oct 29, 2024
20 checks passed
@shakyShane shakyShane deleted the 10-29-ntp_making_the_customizer_menu_more_dynamic branch October 29, 2024 19:47
mallexxx pushed a commit that referenced this pull request Jul 17, 2025
Co-authored-by: Shane Osbourne <sosbourne@duckduckgo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants