Skip to content

ntp: display tweaks + stats show more fix #1288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
shakyShane merged 4 commits into from
Nov 28, 2024
Merged

ntp: display tweaks + stats show more fix #1288

shakyShane merged 4 commits into from
Nov 28, 2024

Conversation

@shakyShane
Copy link
Contributor

@shakyShane shakyShane commented Nov 28, 2024 •
edited
Loading

Asana Task/Github Issue: https://app.asana.com/0/1201141132935289/1208864911781466/f

Description

  • fixed an issue where the track-radar dataset has Example.com, but we only want to show 'Example'
  • fixed a bug where the Show More toggle would break if the list grew after initial expansion

Testing Steps

Checklist

Please tick all that apply:

  • I have tested this change locally
  • I have tested this change locally in all supported browsers
  • This change will be visible to users
  • I have added automated tests that cover this change
  • I have ensured the change is gated by config
  • This change was covered by a ship review
  • This change was covered by a tech design
  • Any dependent config has been merged

@netlify
Copy link

netlify bot commented Nov 28, 2024 •
edited
Loading

✅ Deploy Preview for content-scope-scripts ready!

Name Link
🔨 Latest commit f9deb6b
🔍 Latest deploy log https://app.netlify.com/sites/content-scope-scripts/deploys/67487287bd5b6400082a513e
😎 Deploy Preview https://deploy-preview-1288--content-scope-scripts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@shakyShane
Copy link
Contributor Author

shakyShane commented Nov 28, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions
Copy link

github-actions bot commented Nov 28, 2024 •
edited
Loading

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

@github-actions
Copy link

github-actions bot commented Nov 28, 2024 •
edited
Loading

[Beta] Generated file diff

Time updated: Thu, 28 Nov 2024 13:40:35 GMT

Integration 
    - integration/pages/new-tab/js/index.js

File has changed

Windows 
    - windows/pages/new-tab/js/index.js

File has changed

Apple 
    - dist/pages/new-tab/js/index.js

File has changed

shakyShane
shakyShane commented Nov 28, 2024
View reviewed changes
shakyShane
shakyShane commented Nov 28, 2024
View reviewed changes
shakyShane
shakyShane commented Nov 28, 2024
View reviewed changes
@shakyShane shakyShane marked this pull request as ready for review November 28, 2024 13:39
@shakyShane shakyShane requested review from a team and mgurgel as code owners November 28, 2024 13:39
@shakyShane shakyShane changed the title ntp: display tweaks ntp: display tweaks + stats show more fix Nov 28, 2024
@shakyShane shakyShane merged commit 7923678 into main Nov 28, 2024
20 checks passed
@shakyShane shakyShane deleted the 11-28-ntp_display_tweaks branch November 28, 2024 16:24
mallexxx pushed a commit that referenced this pull request Jul 17, 2025
@shakyShane
ntp: display tweaks + stats show more fix (#1288)
30134da 
* ntp: display tweaks

* added a failing test case

* fixed the implementation

* More robust tests

---------

Co-authored-by: Shane Osbourne <sosbourne@duckduckgo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mgurgel mgurgel mgurgel approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@shakyShane @mgurgel