ntp: fix favorites container when expanded+few items

[shakyShane]

Asana Task/Github Issue: https://app.asana.com/0/0/1208922171943499/f

Description

• The height of the container was broken if the native side's state is both 'expanded' + has no favorites
  • this should not technically occur, and could be fixed on the native side, but it's an easy thing for us to guard against.

Testing Steps

• first, visit https://deploy-preview-1306--content-scope-scripts.netlify.app/build/pages/new-tab/?favorites=10
• expand the favorites list
• then, go to https://deploy-preview-1306--content-scope-scripts.netlify.app/build/pages/new-tab/?favorites=0 to simulate having no favorites
• the height of the container should look correct

Should look like this:

And not this:

Checklist

Please tick all that apply:

• I have tested this change locally
• I have tested this change locally in all supported browsers
• This change will be visible to users
• I have added automated tests that cover this change
• I have ensured the change is gated by config
• This change was covered by a ship review
• This change was covered by a tech design
• Any dependent config has been merged

[shakyShane]

• ntp: fix favorites container when expanded+few items #1306 👈 (View in Graphite)
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[github-actions]

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

• Branch Name: pr-releases/pr-1306
• Commit Hash: 6f29a46369f1a29102af2735333b5b4f4c29f880
• Install Command: npm i github:duckduckgo/content-scope-scripts#6f29a46369f1a29102af2735333b5b4f4c29f880

Please use the above install command to update to the latest version.

[netlify]

✅ Deploy Preview for content-scope-scripts ready!

Name	Link
🔨 Latest commit	19cf68b
🔍 Latest deploy log	https://app.netlify.com/sites/content-scope-scripts/deploys/675302f6dffe000008850583
😎 Deploy Preview	https://deploy-preview-1306--content-scope-scripts.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[github-actions]

[Beta] Generated file diff

Time updated: Fri, 06 Dec 2024 13:59:20 GMT

Integration

    - integration/pages/new-tab/js/index.js

File has changed

Windows

    - windows/pages/new-tab/js/index.js

File has changed

Apple

    - dist/pages/new-tab/js/index.js

File has changed