Skip to content

Conversation

@vkraucunas
Copy link
Contributor

Asana Task/Github Issue: https://app.asana.com/0/0/1208951480757506/f

Description

Testing Steps

Checklist

Please tick all that apply:

  • I have tested this change locally
  • I have tested this change locally in all supported browsers
  • This change will be visible to users
  • I have added automated tests that cover this change
  • I have ensured the change is gated by config
  • This change was covered by a ship review
  • This change was covered by a tech design
  • Any dependent config has been merged

@netlify
Copy link

netlify bot commented Dec 12, 2024

Deploy Preview for content-scope-scripts ready!

Name Link
🔨 Latest commit 3108632
🔍 Latest deploy log https://app.netlify.com/sites/content-scope-scripts/deploys/67609bba0140250008ed5287
😎 Deploy Preview https://deploy-preview-1316--content-scope-scripts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 12, 2024

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 12, 2024

[Beta] Generated file diff

Time updated: Mon, 16 Dec 2024 21:30:27 GMT

Integration
    - integration/pages/new-tab/dist/index.css
  • integration/pages/new-tab/dist/index.js

File has changed

Windows
    - windows/pages/new-tab/dist/index.css
  • windows/pages/new-tab/dist/index.js

File has changed

Apple
    - dist/pages/new-tab/dist/index.css
  • dist/pages/new-tab/dist/index.js

File has changed

@vkraucunas vkraucunas force-pushed the vkraucunas/nextsteps-shipreview-feedback branch from 7464690 to b5d4fca Compare December 16, 2024 17:33
@vkraucunas vkraucunas marked this pull request as ready for review December 16, 2024 17:33
@vkraucunas vkraucunas requested review from a team, mgurgel and shakyShane as code owners December 16, 2024 17:33
@shakyShane shakyShane merged commit 5a9524c into main Dec 16, 2024
12 checks passed
@shakyShane shakyShane deleted the vkraucunas/nextsteps-shipreview-feedback branch December 16, 2024 21:44
mallexxx pushed a commit that referenced this pull request Jul 17, 2025
* chore: Update NextStepsGroup bottom margin

* chore: Increase min-height of card

* chore: Address d4

* fix: Bottom margin

* fix: Add blur to click handler on ShowHideButton

* fix: lint

* chore: wat

* fix: Focus-visible on ShowHideButton implementations. remove blur code

* fix: lint

* fix: card border color

* Added a failing test case for favorites expansion

* fixed favorites positioning

---------

Co-authored-by: Shane Osbourne <shane.osbourne8@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants