Skip to content

Error: Stub out support for theming #2077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
noisysocks merged 1 commit into from
Dec 4, 2025
Merged

Error: Stub out support for theming #2077

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion special-pages/pages/errorpage/public/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
<meta http-equiv="X-UA-Compatible" content="ie=edge">
<link rel="stylesheet" href="style.css">
</head>
<body>
<body data-theme-variant="$THEME_VARIANT$">
<div class="content-container">
<div class="error-container">
<div class="header-container">
Expand All @@ -21,5 +21,16 @@ <h1 class="error-header">$HEADER$</h1>
<img src="img/logo-horizontal.svg" alt="DuckDuckGo" class="watermark">
</div>
</div>
<script>
/**
* Called by native to update the page theme at runtime
* @param {{ themeVariant: string }} payload
*/
window.onChangeTheme = function(payload) {
if (payload && payload.themeVariant) {
document.body.dataset.themeVariant = payload.themeVariant;
}
};
</script>
</body>
</html>
24 changes: 23 additions & 1 deletion special-pages/pages/errorpage/public/style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,4 +65,26 @@ body {
.error-description, .error-header {
color: rgb(210, 210, 210);
}
}
}

/* TODO: Use colour variables from design-tokens */

/* Theme variants - light mode */
[data-theme-variant="coolGray"] { background: #d2d5e3; }
[data-theme-variant="slateBlue"] { background: #d2e5f3; }
[data-theme-variant="green"] { background: #e3eee1; }
[data-theme-variant="violet"] { background: #e7e4f5; }
[data-theme-variant="rose"] { background: #f8ebf5; }
[data-theme-variant="orange"] { background: #fcedd8; }
[data-theme-variant="desert"] { background: #eee9e1; }

/* Theme variants - dark mode */
@media (prefers-color-scheme: dark) {
[data-theme-variant="coolGray"] { background: #2b2f45; }
[data-theme-variant="slateBlue"] { background: #1e3347; }
[data-theme-variant="green"] { background: #203b30; }
[data-theme-variant="violet"] { background: #2e2158; }
[data-theme-variant="rose"] { background: #5b194b; }
[data-theme-variant="orange"] { background: #54240c; }
[data-theme-variant="desert"] { background: #3c3833; }
}
29 changes: 28 additions & 1 deletion special-pages/pages/errorpage/readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,34 @@ So far, the following platforms are supported

- macOS

### Theming

The error page supports theming through two mechanisms:

#### Template Variable: `$THEME_VARIANT$`

Native performs string interpolation to replace `$THEME_VARIANT$` in the HTML with a theme variant name.

If string interpolation is not performed (i.e., `$THEME_VARIANT$` is left as-is), the page falls back to the default styling.

**Supported variants:** `default`, `coolGray`, `slateBlue`, `green`, `violet`, `rose`, `orange`, `desert`

#### Callback: `window.onChangeTheme`

Native can call `window.onChangeTheme(payload)` to update the theme at runtime.

**Payload:**
```json
{
"themeVariant": "coolGray"
}
```

**Example native usage:**
```javascript
window.onChangeTheme({ themeVariant: 'coolGray' });
```

---

## Contributing
Expand All @@ -26,4 +54,3 @@ Don't edit the generated files directly - any changes you make will not be refle

Instead, make your changes in `src/` and then run `npm run build` from the root folder
- or to build the special pages only (faster), run `npm run postbuild` instead

Loading