Skip to content
This repository was archived by the owner on Feb 24, 2025. It is now read-only.

Bitwarden Integration#1399

Merged
tomasstrba merged 5 commits intodevelopfrom
tom/bitwarden
Dec 2, 2022
Merged

Bitwarden Integration#1399
tomasstrba merged 5 commits intodevelopfrom
tom/bitwarden

Conversation

@tomasstrba
Copy link
Copy Markdown
Contributor

@tomasstrba tomasstrba commented Nov 22, 2022

Task/Issue URL: https://app.asana.com/0/72649045549333/1202684343604567/f
Tech Design URL: https://app.asana.com/0/481882893211075/1202715202076385/f
https://app.asana.com/0/481882893211075/1202870974810231/f
CC: @samsymons

Description:
This PR brings BSK changes necessary for Bitwarden integration into macOS app and verifies iOS app is not influenced by the integration at all.

Steps to test this PR:

  1. Test autofill, saving credentials and updating credentials
  2. Make sure there is no issue related to autofill caused by BSK changes

OS Testing:

  • iOS 14
  • iOS 15
  • iOS 16

Internal references:

Software Engineering Expectations
Technical Design Template
When ready for review, remember to post the PR in MM

Copy link
Copy Markdown
Contributor

@samsymons samsymons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, have validated that Autofill is working as expected and tested other features around the edges.

@samsymons samsymons assigned tomasstrba and unassigned samsymons Dec 1, 2022
tomasstrba added a commit to duckduckgo/BrowserServicesKit that referenced this pull request Dec 2, 2022
Bitwarden password manager integrated into macOS app

Task/Issue URL: https://app.asana.com/0/72649045549333/1202684343604567/f
iOS PR: duckduckgo/iOS#1399
macOS PR: duckduckgo/macos-browser#843
@tomasstrba tomasstrba merged commit 55e3ce0 into develop Dec 2, 2022
@tomasstrba tomasstrba deleted the tom/bitwarden branch December 2, 2022 10:49
bershanskiy pushed a commit to bershanskiy/duckduckgo-iOS that referenced this pull request Jan 13, 2023
Task/Issue URL: https://app.asana.com/0/72649045549333/1202684343604567/f
Tech Design URL: https://app.asana.com/0/481882893211075/1202715202076385/f
https://app.asana.com/0/481882893211075/1202870974810231/f

Description:
This PR brings BSK changes necessary for Bitwarden integration into macOS app and verifies iOS app is not influenced by the integration at all.
@jdhauck
Copy link
Copy Markdown

jdhauck commented May 26, 2023

I've been running into issues with the Bitwarden/DDG integration on macOS and was wondering is here the right place to raise them?

@samsymons
Copy link
Copy Markdown
Contributor

Hey @jdhauck! Thanks for bringing this up. The easiest way to deliver feedback to the macOS team is to use the feedback form in the app - you can find this by clicking the "..." button and selecting "Send Feedback".

CleanShot 2023-05-28 at 17 41 08@2x

@jdhauck
Copy link
Copy Markdown

jdhauck commented May 29, 2023

Hi @samsymons. Thank you, I just submitted them through the feedback button. It seems there is no way to follow up with that though, or is there?
Fwiw, I have thus also created a reddit post: https://www.reddit.com/r/duckduckgo/comments/13v64gu/duckduckgobitwarden_integration_problems_in_ddg/

Keep up the good work :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants