Adds VPN Control Center widget and Siri Commands. by diegoreymendez · Pull Request #3414 · duckduckgo/iOS

diegoreymendez · 2024-10-06T15:38:04Z

Task/Issue URL: https://app.asana.com/0/1203108348835387/1208485618883319/f

DRK PR: duckduckgo/DesignResourcesKit#9

Description

Adds a VPN control widget for the control center and lock screen.
Adds Siri commands to control the VPN with voice.

Testing

General

Go to Settings > VPN > VPN Settings > Shortcuts section
Read the education screens and follow their indications to validate them
Test the new CC Widget and Siri commands as per instructions.

Control Center Widget

Go to the control center dashboard
Add a widget
Search for "VPN", and you should see our widget to toggle the VPN on/off. Add it.
You can resize the widget in the dashboard before saving.
Turn the VPN on/off, make sure it works.
Go to the lock screen, press on the background for a few seconds.
Customize your lock screen.
Remove one of the two circle-widgets in the bottom of the lock screen, and add the VPN one.
Make sure it works well.

Definition of Done (Internal Only):

Does this PR satisfy our Definition of Done?

Copy Testing:

Use of correct apostrophes in new copy, ie ’ rather than '

Internal references:

Software Engineering Expectations
Technical Design Template

github-actions · 2024-12-03T09:23:22Z

	Warnings
⚠️	PR has more than 500 lines of code changing. Consider splitting into smaller PRs if possible.

	Messages
📖	You seem to be updating localized strings. Make sure that you request translations and include translated strings before you ship your change. See Localization Guidelines for more information.

Generated by 🚫 dangerJS against 0f9a9ca

Task/Issue URL: https://app.asana.com/0/1207603085593419/1208485618883329/f ## Description Adds Siri support to start and stop the VPN.

DuckDuckGo/NetworkProtectionStatusViewModel.swift

DuckDuckGo/NetworkProtectionVPNSettingsView.swift

DuckDuckGo/NetworkProtectionWidgetRefreshModel.swift

DuckDuckGo/Siri/SiriBubbleView.swift

DuckDuckGo/VPNAutoShortcuts.swift

Core/PixelEvent.swift

DuckDuckGo/DuckDuckGo.entitlements

DuckDuckGo/Info.plist

DuckDuckGo/NetworkProtectionStatusView.swift

LocalPackages/VPNiOS/Sources/VPNWidgetSupport/VPNWidgetTunnelController.swift

LocalPackages/VPNiOS/Package.swift

DuckDuckGo/Widgets/Education/ControlCenterWidgetEducationView.swift

DuckDuckGo/VPNShortcutIntents.swift

DuckDuckGo.xcodeproj/project.pbxproj

samsymons · 2024-12-20T17:56:33Z

DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved

      "state" : {
-        "revision" : "ad133f76501edcb2bfa841e33aebc0da5f92bb5c",
-        "version" : "3.3.0"
+        "revision" : "ba2f7e26575a9529ce268ce16f01760187649ce6"


We'll want to swap this out with a tagged release before merging

DuckDuckGo/Siri/SiriEducationView.swift

DuckDuckGo/VPNAutoShortcuts.swift

samsymons · 2024-12-20T18:02:18Z

DuckDuckGo/VPNAutoShortcuts.swift

+    static var appShortcuts: [AppShortcut] {
+        AppShortcut(intent: EnableVPNIntent(),
+                    phrases: [
+                        "Connect \(.applicationName) VPN",


How should localization be handled for Siri Shortcuts?

This isn't exactly trivial so I'm opening a follow-up task to look into this.

DuckDuckGo/VPNShortcutIntents.swift

DuckDuckGo/Widgets/Education/WidgetEducationView.swift

Co-authored-by: Sam Symons <sam@samsymons.com>

…into diego/vpn-control-widget

samsymons

LGTM after the recent changes, with the acknowledgement that we'll revisit in the new year to sort out localization. But, since this change is gated behind a DEBUG || ALPHA check, it's fine to merge. Thanks!

…ound the build issues

Adds a VPN control widget for the control center and lock screen

3d66ea3

diegoreymendez self-assigned this Oct 6, 2024

diegoreymendez marked this pull request as draft October 6, 2024 15:43

diegoreymendez added 2 commits December 3, 2024 09:29

Merged the latest from main

925493f

Updated the ControlCenter VPN icon

7f58bcc

diegoreymendez and others added 8 commits December 3, 2024 11:11

Implements new Shortcuts section in VPN settings

20d8a76

WIP: Implementing new shortcuts section in VPN settings

f6def20

WIP

dfc9604

WIP

f499f0e

WIP

3acb595

WIP

4940afb

Updates a string

d909c58

Add Siri support to start and stop the VPN. (#3415)

b05a83c

Task/Issue URL: https://app.asana.com/0/1207603085593419/1208485618883329/f ## Description Adds Siri support to start and stop the VPN.

diegoreymendez mentioned this pull request Dec 18, 2024

Add Siri support to start and stop the VPN. #3415

Merged

2 tasks

Merges the latest changes

f39f494

diegoreymendez changed the title ~~Adds a VPN control widget for the control center and lock screen~~ Adds VPN Control Center widget and Siri Commands. Dec 18, 2024