Update ESLint to v10 and fix autoupdate job#3
Conversation
Co-authored-by: siarheidudko <36571430+siarheidudko@users.noreply.github.com>
Co-authored-by: siarheidudko <36571430+siarheidudko@users.noreply.github.com>
|
I don't want to ignore eslint updates @copilot |
There was a problem hiding this comment.
Pull request overview
Updates the repo’s linting/coverage toolchain dependencies and adds guard rails to the autoupdate automation to avoid pulling in major versions that can be incompatible with the project’s current tooling and Node support targets.
Changes:
- Bump
@eslint/js,eslint, andtypescript-eslintdev dependency versions. - Keep
nycpinned to^17.1.0while adding it (and ESLint packages) to autoupdate ignore lists. - Extend both the GitHub autoupdate workflow and
ignoreUpdatesModules.jsonto prevent automated upgrades of selected packages.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| package.json | Updates ESLint + typescript-eslint devDependency versions (keeps nyc at v17). |
| package-lock.json | Refreshes lockfile for the updated tooling versions and their transitive dependencies. |
| ignoreUpdatesModules.json | Adds ESLint packages and nyc to the local update ignore list. |
| .github/workflows/autoupdate.yml | Adds the same packages to the workflow’s autoupdater ignore list. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@copilot fix pr, please |
Co-authored-by: siarheidudko <36571430+siarheidudko@users.noreply.github.com>
Removed ESLint from the ignore lists. ESLint and |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
The autoupdate job was failing because
siarheidudko/autoupdater@v6attempted to install@eslint/js@10.0.1andeslint@10.0.3, which were incompatible withtypescript-eslint@8.54.0.nyc@18.0.0was also being attempted despite requiring Node 20+, conflicting with the package's>=16engine target.Dependency updates
@eslint/js:^9.39.2→^10.0.1eslint:^9.39.2→^10.0.3typescript-eslint:^8.54.0→^8.57.0(adds support foreslint@^10.0.0)globals: added as explicit devDependency (was a transitive dep of ESLint 9, must be direct in ESLint 10)nyc: kept at^17.1.0(v18 drops Node 16/18 support)Auto-updater guard rails
Added
nycto the ignore list in both the autoupdate workflow andignoreUpdatesModules.jsonto prevent the autoupdater from hitting the Node engine incompatibility:ESLint 10 source compatibility fixes
src/utils/protoobject-browser-storage.ts: Replaced the removed/* eslint-env browser */directive (dropped in ESLint 10) with a/* global */comment listing the required browser globals.src/classes/proto-object-fs.ts: Added{ cause: error }to two re-thrown errors to satisfy the newpreserve-caught-errorrule included in ESLint 10's recommended config.Original prompt
💬 Send tasks to Copilot coding agent from Slack and Teams to turn conversations into code. Copilot posts an update in your thread when it's finished.