Skip to content

Update ESLint to v10 and fix autoupdate job#3

Merged
siarheidudko merged 5 commits intomainfrom
copilot/update-dependencies-fix-job
Mar 16, 2026
Merged

Update ESLint to v10 and fix autoupdate job#3
siarheidudko merged 5 commits intomainfrom
copilot/update-dependencies-fix-job

Conversation

Copy link
Contributor

Copilot AI commented Mar 15, 2026

The autoupdate job was failing because siarheidudko/autoupdater@v6 attempted to install @eslint/js@10.0.1 and eslint@10.0.3, which were incompatible with typescript-eslint@8.54.0. nyc@18.0.0 was also being attempted despite requiring Node 20+, conflicting with the package's >=16 engine target.

Dependency updates

  • @eslint/js: ^9.39.2^10.0.1
  • eslint: ^9.39.2^10.0.3
  • typescript-eslint: ^8.54.0^8.57.0 (adds support for eslint@^10.0.0)
  • globals: added as explicit devDependency (was a transitive dep of ESLint 9, must be direct in ESLint 10)
  • nyc: kept at ^17.1.0 (v18 drops Node 16/18 support)

Auto-updater guard rails

Added nyc to the ignore list in both the autoupdate workflow and ignoreUpdatesModules.json to prevent the autoupdater from hitting the Node engine incompatibility:

# .github/workflows/autoupdate.yml
ignore-packages: |
  @types/node
  nyc
// ignoreUpdatesModules.json
{ "base": [], "dev": ["@types/node", "nyc"] }

ESLint 10 source compatibility fixes

  • src/utils/protoobject-browser-storage.ts: Replaced the removed /* eslint-env browser */ directive (dropped in ESLint 10) with a /* global */ comment listing the required browser globals.
  • src/classes/proto-object-fs.ts: Added { cause: error } to two re-thrown errors to satisfy the new preserve-caught-error rule included in ESLint 10's recommended config.
Original prompt

Reference: https://github.com/dudko-dev/protoobject/actions/runs/23102728509/job/67106289299#step:3:1
Update dependencies and fix this job


💬 Send tasks to Copilot coding agent from Slack and Teams to turn conversations into code. Copilot posts an update in your thread when it's finished.

Copilot AI and others added 2 commits March 15, 2026 21:37
Co-authored-by: siarheidudko <36571430+siarheidudko@users.noreply.github.com>
Co-authored-by: siarheidudko <36571430+siarheidudko@users.noreply.github.com>
Copilot AI changed the title [WIP] Update dependencies and fix job Update ESLint/nyc dependencies and prevent incompatible major version auto-upgrades Mar 15, 2026
Copilot AI requested a review from siarheidudko March 15, 2026 21:40
@siarheidudko siarheidudko requested review from Copilot and removed request for siarheidudko March 15, 2026 21:41
@siarheidudko
Copy link
Member

siarheidudko commented Mar 15, 2026

I don't want to ignore eslint updates @copilot

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the repo’s linting/coverage toolchain dependencies and adds guard rails to the autoupdate automation to avoid pulling in major versions that can be incompatible with the project’s current tooling and Node support targets.

Changes:

  • Bump @eslint/js, eslint, and typescript-eslint dev dependency versions.
  • Keep nyc pinned to ^17.1.0 while adding it (and ESLint packages) to autoupdate ignore lists.
  • Extend both the GitHub autoupdate workflow and ignoreUpdatesModules.json to prevent automated upgrades of selected packages.

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.

File Description
package.json Updates ESLint + typescript-eslint devDependency versions (keeps nyc at v17).
package-lock.json Refreshes lockfile for the updated tooling versions and their transitive dependencies.
ignoreUpdatesModules.json Adds ESLint packages and nyc to the local update ignore list.
.github/workflows/autoupdate.yml Adds the same packages to the workflow’s autoupdater ignore list.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@siarheidudko
Copy link
Member

@copilot fix pr, please

Co-authored-by: siarheidudko <36571430+siarheidudko@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Mar 15, 2026

I don't want to ignore eslint updates @copilot

Removed ESLint from the ignore lists. ESLint and @eslint/js are now updated to v10 and will be auto-updated going forward. Only nyc remains ignored (v18 requires Node 20+, the package targets >=16).

Copilot AI changed the title Update ESLint/nyc dependencies and prevent incompatible major version auto-upgrades Update ESLint to v10 and fix autoupdate job Mar 15, 2026
Copilot AI requested a review from siarheidudko March 15, 2026 22:03
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@siarheidudko siarheidudko marked this pull request as ready for review March 16, 2026 07:32
@siarheidudko siarheidudko merged commit 10a8f4d into main Mar 16, 2026
@siarheidudko siarheidudko deleted the copilot/update-dependencies-fix-job branch March 16, 2026 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants