Add more examples#5
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes updates to the
popcorrepository, focusing on improving functionality and code organization for lifter classes and associated utilities. The most significant changes involve refactoring constants and methods in theRangeOnlyLifterclass, enhancing sampling methods, and improving plotting functionality across multiple files. Additionally, documentation and references have been updated for consistency.Updates to lifter classes:
popcor/base_lifters/range_only_lifter.py: Refactored constants such asNOISE,SCALE, andMIN_DISTinto theRangeOnlyLifterclass for better encapsulation. Added new sampling methods (sample_landmarks_filling_space) and improvedsample_thetato avoid numerical issues with landmarks. Introduced warnings for invalid samples after a set number of trials. [1] [2] [3]popcor/base_lifters/state_lifter.py: Added theget_valid_samplesmethod to generate valid samples while ensuring they do not violate constraints. Improved thelocal_solvermethod to handle ignored arguments and added warnings for unsupported method overrides. [1] [2]popcor/examples/rotation_lifter.py: Enhanced theplotmethod to visualize ground truth and estimates using frames. Updatedsample_thetato return matrices instead of flattened arrays for better usability. [1] [2]Enhancements to plotting utilities:
popcor/utils/plotting_tools.py: Updated theplot_framefunction to handle both 2D and 3D rotation matrices (theta) and added support for custom plot markers and line styles. Improved the function's flexibility for visualization purposes. [1] [2]Documentation and reference updates:
CONTRIBUTING.md: Fixed broken links by updating paths to reflect the new repository structure (popcorinstead ofpopr). [1] [2]README.md: Removed redundant documentation deploy badge.(created by Copilot, checked by FD)