fix: add fare brand name to order change offer slices#1125
Merged
Conversation
Co-authored-by: Igor <igorp1@users.noreply.github.com>
andrejak
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fare_brand_nametoOrderChangeOfferSliceso order change offers expose the fare brand in the JS clientTesting
./node_modules/.bin/jest --runInBand src/booking/OrderChangeOffers/OrderChangeOffers.spec.ts./node_modules/.bin/tsc --noEmityarn test(passes as part of the attempted pre-commit hook)Notes
yarn build:teststill fails in this environment during the existing Rollup step becauserollup.config.mjsusesassert { type: 'json' }, which Node 22 rejects. The TypeScript portion completes successfully before that unrelated failure.Linear Issue: TSP-1276