fix(offer requests): tighten OfferRequests types #354
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the `create` method's parameter type allows every parameter to be optional when in reality the endpoint requires `slices` and `passengers` to always be passed along. This fixes that.
go1t
requested review from
igorp1 and
justaddcl
and removed request for
a team
justaddcl
approved these changes
Jan 18, 2022
Contributor
justaddcl
left a comment
justaddcl
left a comment
There was a problem hiding this comment.
Thanks for helping to clean up the types!
lapa182
approved these changes
Jan 18, 2022
|
🎉 This PR is included in version 1.7.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the
createmethod's parameter type allows every parameter to be optional when in reality the endpoint requiresslicesandpassengersto always be passed along. This fixes that.