Skip to content

Conversation

@timrogers
Copy link
Contributor

The Order Cancellations API supports listing order cancellations - optionally filtered by order ID.

This makes that functionality available in the library, with both manual pagination (list) and auto-pagination (listWithGenerator).

This gap in the library was reported by an integrator via a support ticket.

The Order Cancellations API [supports][1] listing order
cancellations - optionally filtered by order ID.

This makes that functionality available in the library, with
both manual pagination (`list`) and auto-pagination
(`listWithGenerator`).

[1]: https://duffel.com/docs/api/order-cancellations/get-order-cancellations
@timrogers timrogers requested a review from a team as a code owner February 14, 2022 23:24
@timrogers timrogers requested review from lapa182 and mcdeguzman99 and removed request for a team February 14, 2022 23:24
@timrogers
Copy link
Contributor Author

I can't get a bunch of tests to pass locally due to output like this:

 FAIL  src/booking/OrderCancellations/OrderCancellations.spec.ts
  ● Test suite failed to run

    Cannot find module 'node:http'
    Require stack:
    - /Users/timrogers/Projects/duffel-api-javascript/node_modules/jest-runtime/build/index.js
    - /Users/timrogers/Projects/duffel-api-javascript/node_modules/jest-runner/build/testWorker.js
    - /Users/timrogers/Projects/duffel-api-javascript/node_modules/jest-worker/build/workers/processChild.js

    Require stack:
      node_modules/jest-runtime/build/index.js
      node_modules/jest-runner/build/testWorker.js
      node_modules/jest-worker/build/workers/processChild.js

      at Runtime._requireCoreModule (node_modules/jest-runtime/build/index.js:1772:12)
      at Object.<anonymous> (node_modules/node-fetch/src/index.js:9:1)

But it seems to be fine in CI! 🧡

Copy link
Contributor

@sgerrand sgerrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this feature! LGTM. 👍

Copy link
Contributor

@igorp1 igorp1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Tim!

@timrogers timrogers merged commit baafe1d into main Feb 15, 2022
@timrogers timrogers deleted the timrogers/order-cancellations-list branch February 15, 2022 09:06
@github-actions
Copy link

🎉 This PR is included in version 1.8.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants