This repository was archived by the owner on Sep 12, 2024. It is now read-only.
Handle null seat details for passengers in an Order
#45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The API documentation for `Order.slices.segments.passengers.seat` said that the value wasn't nullable, which wasn't correct. These changes update the `Order` model to allow that field to be returned with a null value. https://duffel.com/docs/api/orders/schema#orders-schema-slices-slices-segments-slices-segments-passengers-slices-segments-passengers-seat
sgerrand
force-pushed
the
order-handle-null-seat-details
branch
from
c8c11b5 to
eca8f04
Compare
nlopes
approved these changes
Dec 31, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💁 These changes account for
nullvalues potentially being returned forOrder.slices[].segments[].passengers[].seat(docs).