This repository was archived by the owner on Sep 12, 2024. It is now read-only.
Use f-strings in examples output #91
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jesse-c
approved these changes
Jan 31, 2022
Contributor
jesse-c
left a comment
jesse-c
left a comment
There was a problem hiding this comment.
LGTM
The multi-line string approach looks a little un-ideal to me, but I simply may not have seen enough Python, so I'm not sure what exactly to suggest.
Contributor
Author
Yeah, it's crap. I'm going to reverse it and use some inline flake8 directives to get around it. |
Contributor
Author
|
I think 0754593 is a better approach. |
sgerrand
commented
Jan 31, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💁 As recommended by @jesse-c in #90. (comment, comment)