Skip to content

Ability to create temp query#13

Merged
ivpusic merged 2 commits into
mainfrom
temp_query
Mar 4, 2026
Merged

Ability to create temp query#13
ivpusic merged 2 commits into
mainfrom
temp_query

Conversation

@ivpusic
Copy link
Copy Markdown
Member

@ivpusic ivpusic commented Mar 4, 2026

Add support for --temp flag to query create

@ivpusic ivpusic requested a review from va3093 March 4, 2026 13:15
@cursor
Copy link
Copy Markdown

cursor Bot commented Mar 4, 2026

PR Summary

Cursor Bugbot is generating a summary for commit e9f4cf6. Configure here.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Mar 4, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 15fd5bff-7786-41f4-afae-3d262a2c8560

📥 Commits

Reviewing files that changed from the base of the PR and between e9f4cf6 and 3c2212f.

⛔ Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum
📒 Files selected for processing (2)
  • README.md
  • go.mod
🚧 Files skipped from review as they are similar to previous changes (1)
  • README.md

📝 Walkthrough

Walkthrough

Adds a --temp boolean flag to the query create CLI, documents it in the README, wires it into the CreateQueryRequest.IsTemp field, adds a unit test verifying flag behavior, and bumps the duneapi client dependency to v0.4.2.

Changes

Cohort / File(s) Summary
CLI implementation
cmd/query/create.go
Added --temp boolean flag; read flag in runCreate and set CreateQueryRequest.IsTemp.
Tests
cmd/query/create_test.go
Added TestCreateTempFlag to assert CreateQueryRequest.IsTemp is true when --temp is supplied.
Documentation
README.md
Updated CLI usage table to include the optional --temp flag for query create.
Dependencies
go.mod
Bumped github.com/duneanalytics/duneapi-client-go from v0.4.1 to v0.4.2.

Sequence Diagram(s)

mermaid
sequenceDiagram
participant CLI
participant ClientSDK
participant API_Server
CLI->>ClientSDK: parse flags (including --temp) and call CreateQuery(req{IsTemp: true/false})
ClientSDK->>API_Server: POST CreateQuery with IsTemp field
API_Server-->>ClientSDK: returns QueryID / status
ClientSDK-->>CLI: returns result / error

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • Add support for temp queries duneapi-client-go#18 — Introduces IsTemp field in the CreateQueryRequest client SDK used by this change.
  • duneanalytics/core#5670 — Adds IsTemp plumbing through backend query creation handling, matching CLI wiring.
  • duneanalytics/core#5588 — Adds server-side is_temp schema/handler support for temporary queries.

Suggested reviewers

  • va3093
  • norbertdurcansk
🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main change: adding the ability to create temporary queries via the --temp flag.
Description check ✅ Passed The description directly relates to the changeset, specifying the addition of the --temp flag support for the query create command.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (2.5.0)

Error: can't load config: unsupported version of the configuration: "" See https://golangci-lint.run/docs/product/migration-guide for migration instructions
The command is terminated due to an error: can't load config: unsupported version of the configuration: "" See https://golangci-lint.run/docs/product/migration-guide for migration instructions


Comment @coderabbitai help to get the list of available commands and usage tips.

Resolve conflicts in go.mod and go.sum: keep duneapi-client-go v0.4.2
from this branch while adding new dependencies from main.
@ivpusic ivpusic merged commit 0bab0fa into main Mar 4, 2026
1 check passed
@ivpusic ivpusic deleted the temp_query branch March 6, 2026 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants