Skip to content

Add license, update readme#18

Merged
ivpusic merged 2 commits into
mainfrom
license_readme
Mar 6, 2026
Merged

Add license, update readme#18
ivpusic merged 2 commits into
mainfrom
license_readme

Conversation

@ivpusic
Copy link
Copy Markdown
Member

@ivpusic ivpusic commented Mar 6, 2026

Added MIT License file, updated readme with missing commands.

@cursor
Copy link
Copy Markdown

cursor Bot commented Mar 6, 2026

PR Summary

Low Risk
Changes are limited to licensing and documentation updates; no runtime code paths are modified.

Overview
Adds an MIT LICENSE file.

Updates README.md to document interactive dune auth, new/updated flags (--timeout, --no-wait) for query execution/result commands, and the new dataset search-by-contract command; also clarifies that -o/--output applies to all commands except auth.

Removes the obsolete plan/query-commands.md implementation plan.

Written by Cursor Bugbot for commit 93444a9. Configure here.

@ivpusic ivpusic requested a review from va3093 March 6, 2026 11:25
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Mar 6, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: b0bcf8b7-0eac-441b-ad05-05327240cd91

📥 Commits

Reviewing files that changed from the base of the PR and between 93444a9 and 4bd791e.

📒 Files selected for processing (3)
  • .golangci.yml
  • cmd/dataset/search_by_contract_test.go
  • cmd/dataset/search_test.go

📝 Walkthrough

Walkthrough

Adds an MIT LICENSE, updates README with new CLI examples/options (interactive auth, timeouts, dataset search-by-contract, output formatting note), removes the plan/query-commands.md planning document, bumps golangci-lint toolchain, and adds CLI tests + mock support for SearchDatasetsByContractAddress.

Changes

Cohort / File(s) Summary
License
LICENSE
Add MIT License file with 2026 Dune Analytics copyright and standard MIT terms.
Documentation
README.md
Update CLI docs: add interactive dune auth example, add --timeout options to query/run and execution results, document dataset search-by-contract --contract-address command and clarify global output flag support.
Planning docs removed
plan/query-commands.md
Remove entire CLI plan document (complete deletion of planning content and roadmap).
Lint config
.golangci.yml
Bump Go toolchain version reference from 1.22 to 1.25.
CLI tests & mocks
cmd/dataset/search_by_contract_test.go, cmd/dataset/search_test.go
Add unit tests for dataset search-by-contract command and extend test mock with SearchDatasetsByContractAddress method and backing field to support tests.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

  • duneanalytics/duneapi#938 — Adds server-side SearchDatasetsByContractAddress handler and endpoint that the CLI tests/command rely on.
  • duneanalytics/internal-apis#704 — Implements the SearchDatasetsByContractAddress API surface used by the new CLI command.
  • Add support to search contract by address duneapi-client-go#19 — Adds client models/method for searching datasets by contract address, related to the mock/client usage in tests.

Suggested reviewers

  • va3093
  • norbertdurcansk
🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main changes: adding a LICENSE file and updating the README with documentation of missing commands.
Description check ✅ Passed The description is directly related to the changeset, mentioning the addition of an MIT License file and README updates with missing commands.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (2.5.0)

Error: can't load config: unsupported version of the configuration: "" See https://golangci-lint.run/docs/product/migration-guide for migration instructions
The command is terminated due to an error: can't load config: unsupported version of the configuration: "" See https://golangci-lint.run/docs/product/migration-guide for migration instructions


Comment @coderabbitai help to get the list of available commands and usage tips.

@ivpusic ivpusic merged commit d85e934 into main Mar 6, 2026
3 checks passed
@ivpusic ivpusic deleted the license_readme branch March 6, 2026 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants