Update OP v1 tables#1376
Merged
Merged
Conversation
MSilb7
changed the title
jeff-dude
reviewed
Aug 16, 2022
| Lifi LiFi | ||
| Optimistic Exporer Optimistic Explorer - Get Started NFT | ||
| ironbank Iron Bank | ||
| Ironbank Iron Bank |
Member
There was a problem hiding this comment.
postgres seems to treat line 54 & 55 as the same -- likely not case sensitive, leading to duplicates and failed load. i had to remove line 55 to run. will this work?
Member
There was a problem hiding this comment.
i ran if you wanted to check output
| ironbank Iron Bank | ||
| Ironbank Iron Bank | ||
| iron_bank Iron Bank | ||
| Iron_bank Iron Bank |
jeff-dude
approved these changes
Aug 19, 2022
Member
jeff-dude
left a comment
jeff-dude
left a comment
There was a problem hiding this comment.
closing this with the outstanding comments. please open new PR if the changes didn't cover all that was needed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief comments on the purpose of your changes:
Add tokens, contract creators, name mapping.
For Dune Engine V2
I've checked that:
lowercase_snake_casedWhen you are ready for a review, tag duneanalytics/data-experience. We will re-open your forked pull request as an internal pull request. Then your spells will run in dbt and the logs will be avaiable in Github Actions DBT Slim CI. This job will only run the models and tests changed by your PR compared to the production project.