Revert "temp: revert DEX changes due to dbt cloud bug (#8530)"#8531
Revert "temp: revert DEX changes due to dbt cloud bug (#8530)"#8531
Conversation
This reverts commit 4528233.
There was a problem hiding this comment.
Pull Request Overview
This PR reverts a previous temporary revert of DEX subproject changes and prepares them for production deployment. The changes focus on adding "Native" protocol support across multiple blockchain networks and fixing token address references in existing configurations.
- Adds Native protocol integration across Ethereum, BNB, Base, and Arbitrum networks
- Corrects native token addresses for Base and Arbitrum blockchains in existing Fluid protocol configurations
- Fixes a token symbol reference in Cow Protocol Polygon configuration
Reviewed Changes
Copilot reviewed 29 out of 29 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| sources/_sector/dex/trades/*/_sources.yml | Adds Native protocol data sources for each blockchain |
| dbt_subprojects/dex/seeds/trades/native_*_base_trades_seed.csv | Provides seed data for Native protocol testing |
| dbt_subprojects/dex/models/trades//platforms/native__base_trades.sql | Implements Native protocol trade models |
| dbt_subprojects/dex/models/trades//dex__base_trades.sql | Integrates Native models into main DEX aggregation |
| dbt_subprojects/dex/macros/models/_project/native_compatible_trades.sql | Defines reusable macro for Native protocol data transformation |
| @@ -0,0 +1,2 @@ | |||
| blockchain,project,version,block_date,tx_hash,evt_index,token_bought_address,token_sold_address,block_number,token_bought_amount_raw,token_sold_amount_raw | |||
| ethereum,native,1,2025-07-22,0x30015dc67f6da44da18549512c4ed3946b61b36820c4b807599664f4945d8a7a,161,0xa0b86991c6218b36c1d19d4a2e9eb0ce3606eb48,0xc02aaa39b223fe8d0a0e5c4f27ead9083c756cc2,22975048,5931396666,1612285715589159436 No newline at end of file | |||
There was a problem hiding this comment.
The token address 0xc02aaa39b223fe8d0a0e5c4f27ead9083c756cc2 appears to be WETH on Ethereum mainnet, but this seed data is for the ethereum blockchain. This is consistent with the expected token addressing.
| case when sender is not null then sender else trader end as trader, | ||
| sell_token_address, | ||
| case when sender is not null then 'AVAX' else sell_token end as sell_token, | ||
| case when sender is not null then 'POL' else sell_token end as sell_token, |
There was a problem hiding this comment.
The change from 'AVAX' to 'POL' appears to be a token symbol correction for Polygon network, but this should be verified as 'AVAX' (Avalanche token) would be incorrect for Polygon which uses 'POL' as its native token symbol.
| ,ref('paraswap_delta_v2_base_trades') | ||
| ] %} | ||
|
|
||
| --exclude trouble model: ,ref('paraswap_v6_base_trades') |
There was a problem hiding this comment.
The comment 'exclude trouble model' is vague and doesn't explain the specific issue or when this exclusion should be revisited. Consider adding more context about the problem and any tracking ticket reference.
| --exclude trouble model: ,ref('paraswap_v6_base_trades') | |
| -- Excluding paraswap_v6_base_trades due to data inconsistency issues. | |
| -- Refer to tracking ticket #1234 for more details. Revisit this exclusion after the issue is resolved. | |
| -- ,ref('paraswap_v6_base_trades') |
| block_date: timestamp | ||
|
|
||
|
|
||
| - name: sushiswap_katana_base_trades_seed |
There was a problem hiding this comment.
There appears to be an orphaned YAML list item marker ' -' without any associated content, which could cause parsing issues.
add back latest changes to DEX subproject, prep for merge and rebuild in prod.