Fix webhook URL generation to include workflow slug#271
Merged
Conversation
The Activity::webhookUrl() method was generating URLs that didn't match the route pattern registered by Webhooks::registerSignalWebhooks(), causing 404 errors when external services called the webhooks. - Added workflow slug to signal webhook URL generation - Updated test to expect the correct URL format with workflow slug Resolves issue where signal webhooks were failing due to URL mismatch.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #271 +/- ##
===========================================
Coverage 100.00% 100.00%
Complexity 310 310
===========================================
Files 46 46
Lines 1288 1288
===========================================
Hits 1288 1288 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Activity::webhookUrl() method was generating URLs that didn't match the route pattern registered by Webhooks::registerSignalWebhooks(), causing 404 errors when external services called the webhooks.
Resolves issue where signal webhooks were failing due to URL mismatch.
Fixes #269