Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #288 +/- ##
===========================================
Coverage 100.00% 100.00%
Complexity 316 316
===========================================
Files 46 46
Lines 1320 1321 +1
===========================================
+ Hits 1320 1321 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rmcdaniel
pushed a commit
that referenced
this pull request
Apr 17, 2026
- Add apache/avro ^1.12 to composer.json
- New Avro serializer (src/Serializers/Avro.php) with two modes:
- Typed mode: full Avro binary encoding with a caller-provided schema
(int stays int, float stays float — fixes #288)
- Wrapper mode: arbitrary values stored as JSON inside an Avro record
(schemaless fallback, still binary-framed)
- Register 'avro' in CodecRegistry alongside 'json'
- Add 'avro' to universal() codecs (language-neutral)
- Change defaultCodec() from 'json' to 'avro'
- Update config default: serializer => 'avro'
- Suppress PHP 8.4 (double) cast deprecation from apache/avro (#332)
Existing JSON and legacy PHP codec runs continue to decode — the
registry and auto-detection are unchanged. Only new workflows default
to Avro.
Closes #330
Addresses #332
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
rmcdaniel
pushed a commit
that referenced
this pull request
Apr 17, 2026
…rence 8 tests, 35 assertions covering: - Start input round-trips under Avro with type fidelity - Full workflow lifecycle: start -> activity -> signal -> complete - Float/int fidelity (3.14 stays float, 42 stays int) - Every payload row tagged avro (no json codec leaks) - History export includes codec metadata - Schema evolution: v1 payload decodes with v2 reader schema - Negative: non-Avro bytes under avro tag produce typed errors - JSON-tagged-as-avro gets diagnostic mentioning JSON Documents generic wrapper limitation: integer-valued floats like 3.0 lose precision through json_encode (becomes 3). Typed Avro schemas (#288) would fix this; generic wrapper does not.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.