Skip to content

standards: add workspace and CI split#27

Merged
HDauven merged 1 commit into
mainfrom
standards/01-workspace-ci
May 28, 2026
Merged

standards: add workspace and CI split#27
HDauven merged 1 commit into
mainfrom
standards/01-workspace-ci

Conversation

@HDauven
Copy link
Copy Markdown
Member

@HDauven HDauven commented May 27, 2026

Part 1 of the Dusk standards stack.

Adds the plumbing needed to host Dusk contract standards without coupling them to the legacy genesis/test contract workspace:

  • creates a separate standards/ Cargo workspace
  • adds a minimal dusk-contract-standards crate shell
  • restores the root workspace to legacy genesis/test contracts only
  • keeps legacy dependencies on their existing compiler-compatible versions
  • adds standards Makefile targets
  • path-gates CI so standards changes run standards CI while legacy genesis checks stay isolated
  • keeps CI jobs on core

This PR intentionally does not add standards behavior yet. It is the foundation for the following stacked PRs.

Validation:

  • make standards-ci

@HDauven HDauven marked this pull request as ready for review May 27, 2026 14:50
@HDauven HDauven requested a review from moCello May 27, 2026 14:50
Comment thread .github/workflows/ci.yml Outdated
Comment thread README.md Outdated
Comment thread Makefile Outdated
Comment thread rust-toolchain.toml Outdated
Comment thread .github/workflows/ci.yml
Comment thread Cargo.toml Outdated
Copy link
Copy Markdown
Member

@moCello moCello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

REQUEST CHANGES — CI path filter classifies shared root files as standards-only, so legacy clippy/test skip on this PR (confirmed via gh pr checks) despite the toolchain bump; README ships dead links to docs/ and standards/examples/; standards-data-drivers references an undefined make variable and breaks standards-hardening.

@HDauven HDauven force-pushed the standards/01-workspace-ci branch from 8af19c9 to 9e44e76 Compare May 27, 2026 15:52
@HDauven HDauven requested a review from moCello May 27, 2026 15:53
@HDauven HDauven force-pushed the standards/01-workspace-ci branch from 9e44e76 to 16281a0 Compare May 27, 2026 15:55
Comment thread .github/workflows/ci.yml
Copy link
Copy Markdown
Member

@moCello moCello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

APPROVE — all four prior-round blockers fixed cleanly (dorny/paths-filter adopted with shared roots in both filters, README dead links removed, STANDARDS_EXAMPLES defined and guarded, root toolchain pin preserved); one NOTE on filter-list duplication is hygiene, not blocking.

@HDauven
Copy link
Copy Markdown
Member Author

HDauven commented May 28, 2026

Thanks. I opened #34 to track the remaining non-blocking filter-list hygiene note before merging this PR.

@HDauven HDauven merged commit 077a80d into main May 28, 2026
5 checks passed
@HDauven HDauven deleted the standards/01-workspace-ci branch May 28, 2026 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants