Make Wallet transfer gas defaults privacy-aware#19
Merged
Conversation
51c2e13 to
2de98ba
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
2_000_000, shielded/Phoenix transfers default to15_000_000.Context
Testnet Phoenix transfers are currently failing with
Unspendable(OutOfGas)around the old generic transfer default. Current testnet observations show Phoenix transfers spending about10,913,765gas without memo and11,688,779with a small memo, so15_000_000leaves headroom while reducing the public transfer default from the old generic10_000_000.Phoenix spends can also remain in node mempool after the wallet execution watcher times out. A watcher timeout is not proof of transaction failure, and mislabeling it as failed encourages users to retry/bump incorrectly while the same spend/nullifier may still be reserved.
Validation
npm cinpm run test:runnpm run build:chromenpm run build:firefoxNotes
This PR only updates wallet-side defaults and timeout labeling. It does not change node mempool
DEFAULT_MIN_GAS_LIMIT, implement replace-by-fee semantics, or add a manual pending-nullifier cleanup path for stale Phoenix reservations.