Add compatibility for Symfony 4 and 5#29
Merged
dusterio merged 2 commits intodusterio:masterfrom Feb 17, 2021
GCalmels:patch-1
Merged
Add compatibility for Symfony 4 and 5#29dusterio merged 2 commits intodusterio:masterfrom GCalmels:patch-1
dusterio merged 2 commits intodusterio:masterfrom
GCalmels:patch-1
Conversation
Contributor
Author
|
Hey @dusterio, could I have a response to this PR ? You could reject it but I would like to know if I need to find a new package or to fork your repo for a project ? |
|
@dusterio Could you please merge it? Would be important to run with php 8 |
Owner
|
@C0kkie sure thing, thanks! |
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update
symfony/dom-crawlerandsymfony/css-selectorincomposer.jsonto fix #27