Skip to content

test(api): stabilize sparse state query coverage#99

Merged
duyet merged 2 commits into
mainfrom
codex/code-smell-detector-maintenance-20260522
May 22, 2026
Merged

test(api): stabilize sparse state query coverage#99
duyet merged 2 commits into
mainfrom
codex/code-smell-detector-maintenance-20260522

Conversation

@duyet
Copy link
Copy Markdown
Owner

@duyet duyet commented May 22, 2026

Summary

  • Add an explicit timeout to the sparse state-query cap test after full-suite local verification timed out at Vitest's 5s default.
  • Update AGENTS.md, CLAUDE.md, and core memory with the code-smell automation lower-bound workflow and sandbox-safe verification env paths.
  • Replace the stale dashboard maintenance command with the CI-backed cd packages/dashboard && bun run build check.

Evidence

  • Recent scan window: since automation memory timestamp, latest new commit was 000d264 from PR fix(deps): update all non-major dependencies #92 (dependency/CI update); PR fix(deps): update all non-major dependencies #92 and post-merge main CI were green.
  • Dead-code evidence: zero dated review docs remain; exported symbols in recent non-test files had non-test references.
  • Local failure found: packages/api/test/state-platform.test.ts:150 timed out in the full API suite at 5s, then passed in isolation.

Verification

  • bun run lint
  • bun run typecheck
  • targeted sparse-query cap test
  • bun run test (20 files, 307 tests)
  • bun run test:sdk-examples
  • cd packages/dashboard && bun run build

Co-Authored-By: Duyet Le <me@duyet.net>

Co-Authored-By: duyetbot <bot@duyet.net>
Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @duyet, you have reached your weekly rate limit of 500000 diff characters.

Please try again later or upgrade to continue using Sourcery

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 22, 2026

Warning

Rate limit exceeded

@duyet has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 51 minutes and 3 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 08029e66-1a6d-453a-bdfb-906f58e5017b

📥 Commits

Reviewing files that changed from the base of the PR and between 000d264 and c30c915.

📒 Files selected for processing (4)
  • AGENTS.md
  • CLAUDE.md
  • docs/knowledge/core-memory.md
  • packages/api/test/state-platform.test.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/code-smell-detector-maintenance-20260522

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@duyet
Copy link
Copy Markdown
Owner Author

duyet commented May 22, 2026

@codex review

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates project documentation and configuration for automation runs and sandboxed environments, including updates to AGENTS.md, CLAUDE.md, and docs/knowledge/core-memory.md. Key changes include modifying the dashboard build command and increasing the timeout for a sparse query test in packages/api/test/state-platform.test.ts. Feedback was provided to optimize the test performance by parallelizing state seeding.

Comment on lines +159 to +165
for (let index = 0; index < 55; index++) {
await putState(`sparse-capped-miss-${index}`, {
agent_id: "query-agent-sparse-capped",
data: { status: "pending", nested: { priority: "low" } },
tags: ["sparse-capped-miss"],
});
}
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Seeding 55 states sequentially using await in a loop is likely the primary cause of the test timeout. Parallelizing these requests with Promise.all will significantly improve test performance and might even allow for a lower timeout value.

      await Promise.all(
        Array.from({ length: 55 }, (_, index) =>
          putState(`sparse-capped-miss-${index}`, {
            agent_id: "query-agent-sparse-capped",
            data: { status: "pending", nested: { priority: "low" } },
            tags: ["sparse-capped-miss"],
          }),
        ),
      );

@chatgpt-codex-connector
Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Another round soon, please!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Co-Authored-By: Duyet Le <me@duyet.net>

Co-Authored-By: duyetbot <bot@duyet.net>
@duyet
Copy link
Copy Markdown
Owner Author

duyet commented May 22, 2026

@codex review

@chatgpt-codex-connector
Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Nice work!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@duyet
Copy link
Copy Markdown
Owner Author

duyet commented May 22, 2026

@codex review

@duyet duyet merged commit d92292f into main May 22, 2026
6 checks passed
@chatgpt-codex-connector
Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Chef's kiss.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant