Closed
Conversation
xc1427
force-pushed
the
fix/aggregate-export
branch
from
1195af7 to
2b26e1c
Compare
xc1427
changed the title
- correct incorrect re-export syntax for dynamic and isomorphic-fetch - re-organize aggregated export for packages/dva - add missing export in dva/index.d.ts file - fix one throttle test
xc1427
force-pushed
the
fix/aggregate-export
branch
from
2b26e1c to
ec18b03
Compare
sorrycc
reviewed
Aug 5, 2019
| export dynamic from './dynamic'; | ||
| export { connect, connectAdvanced, useSelector, useDispatch, useStore, shallowEqual }; | ||
| export { bindActionCreators }; | ||
| export { default as fetch } from 'isomorphic-fetch'; |
Member
There was a problem hiding this comment.
跑过吗？isomorphic-fetch 好像没 default 的，https://github.com/matthew-andrews/isomorphic-fetch/blob/master/fetch-bower.js#L1
Contributor
Author
There was a problem hiding this comment.
本地没有跑过，但是 CI 是过的。babel 不应该对 es 和 cjs 做兼容吗 ？
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
npm testpassesDescription of change