cmake: Set minimum required version to 3.5 for CMake 4+ compatibility#349
Closed
alperak wants to merge 1 commit intodvidelabs:masterfrom
Closed
cmake: Set minimum required version to 3.5 for CMake 4+ compatibility#349alperak wants to merge 1 commit intodvidelabs:masterfrom
alperak wants to merge 1 commit intodvidelabs:masterfrom
Conversation
Fix: | CMake Error at CMakeLists.txt:2 (cmake_minimum_required): | Compatibility with CMake < 3.5 has been removed from CMake. | | Update the VERSION argument <min> value. Or, use the <min>...<max> syntax | to tell CMake that the project requires at least <min> but has been updated | to work with policies introduced by <max> or earlier. | | Or, add -DCMAKE_POLICY_VERSION_MINIMUM=3.5 to try configuring anyway. | | | -- Configuring incomplete, errors occurred! Signed-off-by: Alper Ak <alperyasinak1@gmail.com>
Contributor
|
Thanks, I'm hesitating a bit on the decision. The current version is too old, but new version might not work on some platforms, and I think there are things in the current CMake files that need to be fixed before bumping. There are also some other PR/issues that I need to consider. Any sugg. are welcome. |
Contributor
|
Bumped CMake to 3.16 in this commit: 385c27b Version 3.16 still allows Appveyor to test MSVC 2015 and should be recent enough. There was quite a bit of work to fix some old custom build rules. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix:
| CMake Error at CMakeLists.txt:2 (cmake_minimum_required):
| Compatibility with CMake < 3.5 has been removed from CMake.
|
| Update the VERSION argument value. Or, use the ... syntax
| to tell CMake that the project requires at least but has been updated
| to work with policies introduced by or earlier.
|
| Or, add -DCMAKE_POLICY_VERSION_MINIMUM=3.5 to try configuring anyway.
|
|
| -- Configuring incomplete, errors occurred!