feat: redemption code UX improvements and E2E verification#239
Merged
feat: redemption code UX improvements and E2E verification#239
Conversation
…2E tests - Server: getCode() now returns creator email/name and user emails for usages - Admin: add details column, copy button, inactive row opacity, delete confirmation dialog - Admin: create dialog shows generated code with copy on success instead of auto-closing - Admin: detail dialog displays creator email and user email, capitalizes membership tier - PC: redeem code button uses primary variant, add Discord hint below input - i18n: add discordCodeHint key to all 5 languages (en, zh-CN, ja, de, ar) - E2E: add 10-scenario live server test covering full redemption lifecycle
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getCode()enriches response with creator email/name and redeemer user emails (batch query)E2E verification
Ran against
server.moryflow.com— 8/10 passed. 2 failures are expected: tests 4 and 10 assertcreator.emailanduserEmailfields which require this PR's server changes to be deployed first.Test plan
pnpm --filter @moryflow/server exec tsc --noEmit— passpnpm --filter @moryflow/admin build— passpnpm --filter @moryflow/pc build— pass