Merged
Conversation
|
Commenting on this only PR as the repo does not allow issues This CSV is working fine: and outputs This CSV is broken: and outputs and additional "u" to the email field breaks the row parsing as you can see, i've encountered this issue with different lengths of the email field. Hope this info could be useful |
Owner
|
Hi @SStoliarchuk, the project has issues disabled as no support is available. Please submit a to PR to fix the issue or use an alternate project. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello @dw, just a PR to document how to install the lib on ubuntu etc. because it is failing right now because, on linux, install will default to gcc compilation most of the time and your files cannot be compiled using gcc because of the following error (note that I am using py3):
related to this piece of code:
PyTypeObject CellType = { PyVarObject_HEAD_INIT(NULL, 0) .tp_name = "_Cell", .tp_basicsize = sizeof(CellObject), .tp_dealloc = cell_dealloc, #if PY_MAJOR_VERSION < 3 .tp_compare = cell_compare, #endif .tp_flags=Py_TPFLAGS_DEFAULT, .tp_doc="csvmonkey._Cell", .tp_richcompare=cell_richcmp, .tp_methods=cell_methods, };I'd fix it myself if I could but I don't know much about C++.
Have a good day and thanks for your library.