Skip to content

Documenting install discrepancies on linux#8

Merged
dw merged 1 commit intodw:masterfrom
Yomguithereal:master
Aug 26, 2021
Merged

Documenting install discrepancies on linux#8
dw merged 1 commit intodw:masterfrom
Yomguithereal:master

Conversation

@Yomguithereal
Copy link
Copy Markdown
Contributor

Hello @dw, just a PR to document how to install the lib on ubuntu etc. because it is failing right now because, on linux, install will default to gcc compilation most of the time and your files cannot be compiled using gcc because of the following error (note that I am using py3):

cpython/csvmonkey.cpp:933:1: sorry, unimplemented: non-trivial designated initializers not supported

related to this piece of code:

PyTypeObject CellType = {
    PyVarObject_HEAD_INIT(NULL, 0)
    .tp_name = "_Cell",
    .tp_basicsize = sizeof(CellObject),
    .tp_dealloc = cell_dealloc,
#if PY_MAJOR_VERSION < 3
    .tp_compare = cell_compare,
#endif
    .tp_flags=Py_TPFLAGS_DEFAULT,
    .tp_doc="csvmonkey._Cell",
    .tp_richcompare=cell_richcmp,
    .tp_methods=cell_methods,
};

I'd fix it myself if I could but I don't know much about C++.

Have a good day and thanks for your library.

@SStoliarchuk
Copy link
Copy Markdown

Commenting on this only PR as the repo does not allow issues

This CSV is working fine:

mobile,name,email,city,active
3300000000,textppsyvjnlc,textnrnixwotext,texttqn1loq39,1

and outputs
{'mobile': '3300000000', 'name': 'textppsyvjnlc', 'email': 'textnrnixwotext', 'city': 'texttqn1loq39', 'active': '1'}>

This CSV is broken:

mobile,name,email,city,active
3300000000,textppsyvjnlc,textnrnixwotextu,texttqn1loq39,1

and outputs
{'mobile': '3300000000', 'name': 'textppsyvjnlc', 'email': 'textnrnixwotextu|texttqn1loq39|1'}

and additional "u" to the email field breaks the row parsing as you can see, i've encountered this issue with different lengths of the email field.

Hope this info could be useful

@dw dw merged commit 560e89a into dw:master Aug 26, 2021
@dw
Copy link
Copy Markdown
Owner

dw commented Aug 26, 2021

Hi @SStoliarchuk, the project has issues disabled as no support is available. Please submit a to PR to fix the issue or use an alternate project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants