Add offset to dqm#838
Merged
Merged
Conversation
…et in `add_linear_equality_constraint`
…_offset_to_dqm
arcondello
reviewed
Jun 9, 2021
…` at python layer to match order of `DQMVectors` namedtuple.
arcondello
reviewed
Jun 10, 2021
arcondello
reviewed
Jun 10, 2021
arcondello
reviewed
Jun 10, 2021
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #838 +/- ##
==========================================
+ Coverage 88.26% 88.28% +0.02%
==========================================
Files 70 70
Lines 5862 5874 +12
==========================================
+ Hits 5174 5186 +12
Misses 688 688 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
hsadeghidw
approved these changes
Jun 11, 2021
arcondello
approved these changes
Jun 11, 2021
arcondello
added a commit
that referenced
this pull request
Jun 11, 2021
New Features ------------ * Add `add_bqm` method to C++ BinaryQuadraticModel #821, #823 * Add `Structured.valid_bqm_graph` method for verifying input problem structure #832 * Reimplement `BinaryQuadraticModel` to use new C++ code #828 * `BinaryQuadraticModel` can now be manipulated symbolically #834 * `load` function can now load all model types #841, #843 * `DiscreteQuadraticModel` now has an `.offset` attribute #838 * Add `ConstrainedQuadraticModel` class #839 Fix --- * Fix type promotions in binary quadratic models with object biases #836
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: Publishing before it's ready to merge to get eyes on it.
Implement offset in DQM object via underlying
cyDiscreteQuadraticModelobject.Update methods in backwards compatibility safe way.
Add new tests and update existing tests to reflect offset.
Closes #744