Add sparse set domains#515
Merged
alexzucca90 merged 2 commits intodwavesystems:constraint-programmingfrom Apr 22, 2026
Merged
Conversation
Member
|
Seems like we'll want a separate container-like |
arcondello
reviewed
Apr 21, 2026
| class SparseSetArray : public DomainArray { | ||
| public: | ||
| SparseSetArray(StateManager* sm, ssize_t min_size, ssize_t max_size, ssize_t lb, ssize_t ub); | ||
| // SparseSetArray(StateManager* sm, ssize_t size, ssize_t lb, ssize_t ub); |
Member
There was a problem hiding this comment.
lots of commented out functions, here and elsewhere.
|
|
||
| private: | ||
| std::vector<ssize_t> n_; | ||
| std::vector<ssize_t> ofs_; |
Member
There was a problem hiding this comment.
This is quite terse. Could we make these clearer or add a comment explaining what they are?
arcondello
approved these changes
Apr 22, 2026
Member
arcondello
left a comment
arcondello
left a comment
There was a problem hiding this comment.
Probably needs an overall documentation pass, but I think this is fine to merge into the development branch
alexzucca90
merged commit 409c266
into
dwavesystems:constraint-programming
14 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.