Use buffer_ptr inside predicate skips #25
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While I can't reproduce this bug in the test suite, I suspect that in some cases the value decoding will run over the end of the buffer. This is because the buffer is not NUL terminated, and the code was originally expecting to perform this in-situ on the original buffer, which was both NUL-terminated and within known delimiters.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While I can't reproduce this bug in the test suite, I suspect that in some cases the value decoding will run over the end of the buffer.
This is because the buffer is not NUL terminated, and the code was originally expecting to perform this in-situ on the original buffer, which was both NUL-terminated and within known delimiters.