Update all dependencies #26
Conversation
|
I've also discovered the library a few days ago and find great value in it. The update would be very welcome. |
build.sbt
Outdated
| lazy val scala213 = "2.13.7" | ||
| lazy val scala212 = "2.12.15" | ||
| lazy val scala211 = "2.11.12" | ||
| lazy val scala3 = "3.6.3" |
There was a problem hiding this comment.
Based on my reading https://www.scala-lang.org/blog/2022/08/17/long-term-compatibility-plans.html#library-maintainers, I think we need to publish for Scala 3.3 LTS. Is that right? It also says I'll need to bump the major version number.
There was a problem hiding this comment.
Yes, that's my mistake 3.3 is the LTS and the correct version for libs. I'll change this tomorrow and have a look about whether this has to be a major release.
There was a problem hiding this comment.
Is updated.
My understanding of the documentation is that you need to bump to 4.1.0.
"Remember that when you bump the minor version of the compiler (e.g., moving from the previous Scala LTS line to the next), you also need to bump the minor version of your library."
The scala version change is from 3.0 to 3.3 which is a minor so the bump here should also be a minor.
There was a problem hiding this comment.
You're right, I must have misread major instead of minor
|
The build failure is because sbt is no longer included on ubuntu-latest. We'll need to use https://github.com/sbt/setup-sbt |
|
I fixed the CI issue if you rebase master |
Updates scala and all dependencies Removed support for scala 2.11 as it has reached EOL in 2016
thanks! I rebased |
|
Released v4.1.0 🎉 Thanks again! |
|
Thanks all for this. I would suggest setting up RenovateBot GitHub App (or optionally a scheduled GH Action) or Scala-Steward to get automated PRs for new dependencies. I've got a slight preference for RenovateBot because it can also handle many other things that Scala Steward cannot but Scala Steward can be more useful for the "niche Scala stuff" like auto-reformatting when scalafmt is upgraded or better handling cross Scala versions declaration. EDIT: I will actually open a dedicated issue for follow-up. |
4 participants
Hi, thanks for creating this, it is very useful.
It would be nice to have this published with more current Scala versions.
This pull request updates all dependencies to the current versions. It also drops support for Scala 2.11 as it reached EOL in 2016 (and the newer dependencies do not support it).