Replaced jest with vitest ⚡️ #224
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwightjack
reviewed
Mar 3, 2022
Owner
dwightjack
left a comment
dwightjack
left a comment
There was a problem hiding this comment.
Great!
I have added a couple of comments and a possible fix for code coverage.
Thanks! 🙇
Collaborator
Author
|
Yeah I will had |
Collaborator
Author
|
Added your recommendations and fixed coverage config! |
victorgarciaesgi
changed the title
dwightjack
approved these changes
Mar 3, 2022
Owner
dwightjack
left a comment
dwightjack
left a comment
There was a problem hiding this comment.
Perfect! I can see the results on codeclimate.
Let's merge this! Thanks again!
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP but localy the tests are already working. It was faster than I expected.
There are still issues with coverage in the CI I think. I don't have much experience with that aspect