feat: use pipx to install pre-commit if uvx is not installed#57
Merged
feat: use pipx to install pre-commit if uvx is not installed#57
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds a fallback mechanism to install pre-commit hooks using pipx when uvx is not available. Previously, the function would silently return if uvx was not installed, leaving pre-commit hooks uninstalled.
Key changes:
- Modified the control flow to check for
uvxfirst, then fall back topipxif available - Added pipx-based pre-commit installation logic mirroring the uvx implementation
- Updated the pipx workflow test to verify the new pipx installation path
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/gimmegit/_cli.py | Changed from early return to if-elif structure, adding pipx as fallback for pre-commit installation |
| .github/workflows/pipx.yaml | Added assertions to verify pipx is used for pre-commit installation in the test workflow |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.