feat: install pre-commit using gimmegit dependency#59
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR simplifies the pre-commit installation process by making it a direct dependency of gimmegit, eliminating the need to call external tools like uvx or pipx. The output messaging is also consolidated from two lines to one for better user experience. Additionally, the PR standardizes error message formatting by adding consistent punctuation.
- Adds
pre-commitas a project dependency - Simplifies installation logic to use the pre-commit executable directly
- Updates all test expectations to reflect the new single-line output message
- Standardizes error message formatting with trailing periods
Reviewed changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| pyproject.toml | Adds pre-commit as a direct dependency |
| src/gimmegit/_cli.py | Refactors install_pre_commit to use direct pre-commit executable instead of uvx/pipx |
| src/gimmegit/_status.py | Adds period to error message for consistency |
| tests/unit/test_status.py | Updates test assertion to match new error message format |
| tests/functional/test_clone.py | Updates expected output to reflect new single-line pre-commit message |
| tests/functional/test_return_dir.py | Updates expected output to reflect new single-line pre-commit message |
| tests/functional/test_token.py | Updates expected output to reflect new single-line pre-commit message |
| .github/workflows/pipx.yaml | Updates CI workflow to check for new pre-commit output message |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Owner
Author
|
@copilot this PR has a failing check (pipx). Please review the changes to understand why the check is failing, then work on a fix. |
9 tasks
Contributor
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: dwilding <1141260+dwilding@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes the
pre-commitas a dependency ofgimmegit, removing the need to call out touvxorpipx. I've also compressed the output from two lines to one.Before:
After:
This PR also includes a small unrelated change to make runtime error messages have consistent formatting.