Skip to content

feat: install pre-commit using gimmegit dependency#59

Merged
dwilding merged 7 commits intomainfrom
pre-commit-dep
Dec 9, 2025
Merged

feat: install pre-commit using gimmegit dependency#59
dwilding merged 7 commits intomainfrom
pre-commit-dep

Conversation

@dwilding
Copy link
Copy Markdown
Owner

@dwilding dwilding commented Dec 9, 2025

This PR includes the pre-commit as a dependency of gimmegit, removing the need to call out to uvx or pipx. I've also compressed the output from two lines to one.

Before:

Installing pre-commit using uvx
pre-commit installed at .git/hooks/pre-commit

After:

Installing pre-commit hook

This PR also includes a small unrelated change to make runtime error messages have consistent formatting.

Copilot AI review requested due to automatic review settings December 9, 2025 11:03
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR simplifies the pre-commit installation process by making it a direct dependency of gimmegit, eliminating the need to call external tools like uvx or pipx. The output messaging is also consolidated from two lines to one for better user experience. Additionally, the PR standardizes error message formatting by adding consistent punctuation.

  • Adds pre-commit as a project dependency
  • Simplifies installation logic to use the pre-commit executable directly
  • Updates all test expectations to reflect the new single-line output message
  • Standardizes error message formatting with trailing periods

Reviewed changes

Copilot reviewed 8 out of 9 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
pyproject.toml Adds pre-commit as a direct dependency
src/gimmegit/_cli.py Refactors install_pre_commit to use direct pre-commit executable instead of uvx/pipx
src/gimmegit/_status.py Adds period to error message for consistency
tests/unit/test_status.py Updates test assertion to match new error message format
tests/functional/test_clone.py Updates expected output to reflect new single-line pre-commit message
tests/functional/test_return_dir.py Updates expected output to reflect new single-line pre-commit message
tests/functional/test_token.py Updates expected output to reflect new single-line pre-commit message
.github/workflows/pipx.yaml Updates CI workflow to check for new pre-commit output message

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/gimmegit/_cli.py Outdated
@dwilding
Copy link
Copy Markdown
Owner Author

dwilding commented Dec 9, 2025

@copilot this PR has a failing check (pipx). Please review the changes to understand why the check is failing, then work on a fix.

Copy link
Copy Markdown
Contributor

Copilot AI commented Dec 9, 2025

@dwilding I've opened a new pull request, #60, to work on those changes. Once the pull request is ready, I'll request review from you.

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: dwilding <1141260+dwilding@users.noreply.github.com>
@dwilding dwilding merged commit 4b82143 into main Dec 9, 2025
4 checks passed
@dwilding dwilding deleted the pre-commit-dep branch December 9, 2025 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants