fix: clarify error message about review branch#71
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR clarifies an error message that appears when a user attempts to compare branches (gimmegit -c) before pushing the review branch to GitHub. The updated message provides actionable guidance by explicitly instructing the user to push to GitHub first.
Key Changes
- Updated error message from "The review branch has not been created." to "The review branch has not been created. Push to GitHub first."
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/gimmegit/_cli.py | Updated the error message in the compare_usage function to include instruction to push to GitHub |
| tests/functional/test_clone.py | Updated the expected error message in the test to match the new message |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running
gimmegit -c, if the branch hasn't been pushed to GitHub, gimmegit exits with this message:This PR clarifies the intent of the message. Updated message: