Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates gimmegit to support Python 3.10 by adjusting an argparse flag implementation that crashes on 3.10 and by lowering the project’s declared minimum Python version, then validating that support in CI.
Changes:
- Lower the minimum supported Python version from 3.11 to 3.10 (project metadata + lockfile).
- Fix CLI flag parsing to avoid Python 3.10’s
argparsestore_constbehavior (switch tostore_truefor--compare,--help,--version). - Expand CI coverage to run unit/functional tests on Python 3.10.
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
pyproject.toml |
Lowers requires-python to >= 3.10. |
uv.lock |
Updates lock metadata and resolved deps for Python 3.10 compatibility (incl. backports/markers). |
src/gimmegit/_args.py |
Replaces store_const flags with store_true to fix Python 3.10 crash. |
src/gimmegit/_cli.py |
Replaces typing.Never with typing.NoReturn for Python 3.10 compatibility. |
.github/workflows/unit.yaml |
Adds Python 3.10 to the unit-test matrix. |
.github/workflows/functional-full.yaml |
Adds Python 3.10 to the functional test matrix. |
.github/workflows/functional-limited.yaml |
Runs the limited functional job on Python 3.10. |
dwilding
commented
Feb 25, 2026
Comment on lines
+37
to
+39
| parser.add_argument("-c", "--compare", action="store_true") # The value isn't significant. | ||
| parser.add_argument("-h", "--help", action="store_true") # The value isn't significant. | ||
| parser.add_argument("--version", action="store_true") # The value isn't significant. |
Owner
Author
There was a problem hiding this comment.
By "the value isn't significant", I mean that the code never checks the value of these arguments. We only check whether they exist. By default, they don't exist, because we've set argument_default=argparse.SUPPRESS (which we need for being able to distinguish between missing/default values of other arguments).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for Python 3.10, which gimmegit was very close to supporting already. Fixes #86.