revert: clone all branches and defer check for existing branch#92
Merged
revert: clone all branches and defer check for existing branch#92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reverts #78 and #83, which were released in version 0.5.0. In practice, I found that gimmegit completes faster if it clones the entire repo at once (all branches) instead of initially cloning with
--single-branch.In the case of cloning and creating a new branch, we now check for a branch conflict after cloning. This doesn't fail as quickly, but I can accept that trade-off as I've rarely hit a branch conflict.
With
-j/--jumbo, we still check for a branch conflict before cloning. When shallow cloning, we don't necessarily get refs created for all branches on the remote.