Open
Conversation
Abort in-flight run/poll requests in the editor UI and trigger best-effort runtime container termination on cancel so Stop takes effect immediately and ignores late output.
Member
|
looks like quality checks are failing. |
Mark the runtime cancellation check as impure so PHPStan does not collapse repeated checks and incorrectly fail the quality pipeline for the stop-action fix.
Member
|
Add technical documentation. |
Clarify the two-phase cancellation flow so Stop semantics are explicit and operationally reliable, including immediate UI hard-stop handling and backend interruption safeguards.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WorkspaceToolingServiceInterfaceto preserve architecture boundaries.Test plan
mise run tests:frontendmise run testsmise run npm exec -- eslint src/ChatBasedContentEditor/Presentation/Resources/assets/controllers/chat_based_content_editor_controller.ts tests/frontend/integration/ChatBasedContentEditor/chat_editor_controller.test.tsmise run quality(fails in this workspace due untracked.productbuilder-runtimefiles being linted; repo changes themselves pass targeted lint/tests above)Closes #94