Skip to content
This repository was archived by the owner on Mar 18, 2024. It is now read-only.

fix(metrics): change api module from splunk logging to axios#1304

Merged
azlam-abdulsalam merged 12 commits intodxatscale:mainfrom
Rocko1204:fix-splunk-sender
May 8, 2023
Merged

fix(metrics): change api module from splunk logging to axios#1304
azlam-abdulsalam merged 12 commits intodxatscale:mainfrom
Rocko1204:fix-splunk-sender

Conversation

@Rocko1204
Copy link
Copy Markdown
Contributor

  • change api module to axios
  • delete message property from JSON payload
  • change logic to use splunk urls without ports

Checklist

All items have to be completed before a PR is merged

  • Adhere to Contribution Guidelines
  • Updates to Decision Records considered?
  • Updates to documentation at DX@Scale Guide considered?
  • Tested changes?
  • Unit Tests new and existing passing locally?

@reviewpad
Copy link
Copy Markdown

reviewpad Bot commented May 3, 2023

AI-Generated Summary: This pull request includes changes to dependencies, package-lock.json, and the core package. In packages/core/package.json, the axios package has been added, and the splunk-logging package has been removed. The sfpowerscripts-cli package-lock.json has been updated, with the addition of splunk-logging and nested dependencies for needle, debug, and sax. The core package's SplunkMetricSender class has been modified to replace the original SplunkLogger with an AxiosInstance for sending metrics, simplifying the sendGaugeMetric and sendCountMetric methods in the process.

@reviewpad reviewpad Bot requested a review from azlam-abdulsalam May 3, 2023 07:44
@reviewpad reviewpad Bot added large Pull request is large waiting-for-review labels May 3, 2023
@reviewpad
Copy link
Copy Markdown

reviewpad Bot commented May 3, 2023

Reviewpad Report

‼️ Errors

  • Unconventional commit detected: 'Merge branch 'main' into main' (8607f8b)
  • Unconventional commit detected: 'Merge branch 'main' into main' (ba9f14b)
  • Unconventional commit detected: 'Merge remote-tracking branch 'upstream/main'' (791b9fb)
  • Unconventional commit detected: 'Merge branch 'main' into fix-splunk-sender' (a7127e7)

⚠️ Warnings

  • Please link an issue to the pull request

@reviewpad
Copy link
Copy Markdown

reviewpad Bot commented May 3, 2023

AI-Generated Summary: This pull request contains updates to several files, including configuration changes, dependency updates, and code refactoring. In the packages/core/jest.config.js, a new moduleNameMapper property has been added for the axios library. The packages/core/package.json file now includes the axios package and has removed the splunk-logging package. The sfpowerscripts-cli package-lock.json shows an update for '@dxatscale/sfpowerscripts.core' and addition of some new dependencies. Finally, the SplunkMetricSender.ts file has been refactored to replace the splunk-logging library with axios for sending metrics to Splunk, streamlining the code and simplifying the process.

Copy link
Copy Markdown
Contributor

@azlam-abdulsalam azlam-abdulsalam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okie

@reviewpad reviewpad Bot requested a review from azlam-abdulsalam May 8, 2023 21:25
@azlam-abdulsalam azlam-abdulsalam merged commit 7b36efd into dxatscale:main May 8, 2023
@reviewpad
Copy link
Copy Markdown

reviewpad Bot commented May 8, 2023

AI-Generated Summary: This pull request includes changes to dependencies, configurations, and code implementation, specifically: addition of the axios package as a dependency in the 'core' package, removal of the splunk-logging package, updates to the jest.config.js configuration to properly utilize the Axios library in tests, update of the '@dxatscale/sfpowerscripts.core' package version, addition of 'splunk-logging', 'needle', 'debug', and 'sax' packages as dependencies, and finally, updates to the SplunkMetricSender class to use Axios instead of the splunk-logging package for sending HTTP requests, simplifying the code while maintaining the same functionality.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

large Pull request is large waiting-for-review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants