Select redesign #2154
Merged
Select redesign #2154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mil4n0r
requested changes
Feb 20, 2025
Collaborator
|
Only docs missing |
Collaborator
Author
|
Select documentation ready to be reviewed! |
Mil4n0r
requested changes
Mar 10, 2025
Collaborator
Mil4n0r
left a comment
Mil4n0r
left a comment
There was a problem hiding this comment.
Story for opinionated theme should be removed.
Collaborator
|
The visual tests for datagrid, paginator and resultsettable will be adressed in the paginator PR |
Mil4n0r
requested changes
Mar 12, 2025
Mil4n0r
approved these changes
Mar 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
/libdirectory./websiteas needed.Description
Redesign of the select component following the new design kit specifications, already using the new token architecture (CSS variables). This PR includes a few accessibility updates regarding arias and roles, found through the reimplementation (the links are above).
Additional context
Figma designs
Select combobox pattern - We will follow this pattern when we have single options.
Listbox with groups pattern - We will follow this pattern when we have groped options.