Conversation
There was a problem hiding this comment.
Codex Review: Here are some suggestions.
Reply with @codex fix comments to fix any unresolved comments.
About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".
| [Files] | ||
| Source: "dist\encrypted_chat_client.exe"; DestDir: "{app}"; Flags: ignoreversion |
There was a problem hiding this comment.
[P1] Include encryption key file in installer instructions
The packaging guide instructs Inno Setup to ship only encrypted_chat_client.exe, but the client code opens key.key on startup (encrypted_chat/encrypted_chat_client.py lines 4‑7). Following these steps produces an installer that installs an executable with no key file, so the application crashes with FileNotFoundError the first time the user launches it. Please update the instructions (and the Inno script example) to include or generate the key file alongside the executable so the installed client can actually start.
Useful? React with 👍 / 👎.
Summary
requirements.txtTesting
python -m py_compile encrypted_chat/*.pyhttps://chatgpt.com/codex/tasks/task_e_68bb0ee9c834832b856c4112f142c1ec