Fix ASI before accessor keyword identifiers#33
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
get/setaccessor parser can treat an identifier followed by a statement with a parenthesized head and block body as accessor syntax when a semicolon or line break separates them.That should parse as two statements, but the accessor parser can read it as if it were
set for (...) { ... }inside the returned expression.Fix
Reject accessor parsing when a semicolon boundary or line terminator appears between the
get/setkeyword candidate and the property name. In that case,get/setfalls back to the normal identifier path and ASI can split the following statement correctly.Validation
return set;followed by aforblocknode test/jessie.js: 71 tests, 243 assertions