Skip to content

Add list subcommand for manifest accounts#494

Merged
dyc3 merged 2 commits into
masterfrom
pullfrog/0-add-list-subcommand
Apr 14, 2026
Merged

Add list subcommand for manifest accounts#494
dyc3 merged 2 commits into
masterfrom
pullfrog/0-add-list-subcommand

Conversation

@pullfrog
Copy link
Copy Markdown
Contributor

@pullfrog pullfrog Bot commented Apr 14, 2026

closes #391

What changed

  • added a new list subcommand to print account names from manifest.json
  • wired the command into clap subcommands and runtime dispatch
  • added unit tests for list extraction behavior and kept CLI shape validation covered by existing verify_cli test

Notes

  • list now runs before auto-upgrade logic so it does not mutate manifest/account files
  • if the manifest requires migration, list exits with a clear error instead of modifying data

Testing

  • cargo test list::tests::
  • cargo test commands::tests::verify_cli
  • cargo fmt --check

Pullfrog  | View workflow run | Triggered by Pullfrog | Using GPT Codex𝕏

@pullfrog pullfrog Bot requested a review from dyc3 April 14, 2026 17:40
@dyc3
Copy link
Copy Markdown
Owner

dyc3 commented Apr 14, 2026

@pullfrog fix ci

@pullfrog
Copy link
Copy Markdown
Contributor Author

pullfrog Bot commented Apr 14, 2026

Identified the CI failure in the Clippy step as clippy::useless_vec in src/commands/list.rs test code, introduced by this PR. Replaced the unnecessary vec![] with an array literal in account_names_preserves_manifest_order, then re-ran the exact CI command cargo clippy --workspace --no-deps --all-features --all-targets -- -D warnings successfully. Pushed commit ce7dd10 to pullfrog/0-add-list-subcommand.

Task list (5/5 completed)
  • Checkout PR Add list subcommand for manifest accounts #494 branch locally
  • Retrieve CI check suite logs and identify failing command
  • Confirm failure is introduced by this PR
  • Implement fix and rerun exact CI command locally
  • Commit fix, push branch, and report progress

Pullfrog  | View workflow run | Triggered by Pullfrog | Using GPT Codex𝕏

@dyc3 dyc3 merged commit ea80ddf into master Apr 14, 2026
3 checks passed
@dyc3 dyc3 deleted the pullfrog/0-add-list-subcommand branch April 14, 2026 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

List of account

1 participant